Use vim.on_key for keymap #487
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
2 tasks
2 tasks
|
|
Originally I had planned to up the minimum version to 0.11 before marking as stable, but I realized that would leave a lot of people on stable distros without support. So I'm planning to use this for v2 of the plugin instead! |
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
vim.on_keyfor the keymap instead of defining keymaps with complicated fallback logic. Requires neovim 0.11 and currently doesn't have support for multiple keys (i.e.<C-g><C-o>) yet. Thanks @hrsh7th for recommending this! Related #482I'll wait for 0.11 to release before merging, since I'd rather not maintain two different code paths for keymaps
Closes #406
Closes #453
Closes #289
Closes #714